CVE-2026-34585: SiYuan Knowledge System RCE Vulnerability

CVE-2026-34585 Overview

CVE-2026-34585 is a stored Cross-Site Scripting (XSS) vulnerability in SiYuan, a personal knowledge management system, that can escalate to Remote Code Execution (RCE) in the Electron desktop client. Prior to version 3.6.2, the application fails to properly sanitize crafted block attribute values when an HTML entity is mixed with raw special characters, allowing attackers to bypass server-side attribute escaping mechanisms.

Critical Impact

This vulnerability enables attackers to achieve full remote code execution on victim systems through maliciously crafted .sy.zip document imports. In the Electron desktop client, injected JavaScript gains access to Node.js and Electron APIs, allowing complete system compromise.

Affected Products

• SiYuan versions prior to 3.6.2
• SiYuan Electron desktop client (all platforms)
• SiYuan installations supporting .sy.zip document import

Discovery Timeline

• 2026-03-31 - CVE-2026-34585 published to NVD
• 2026-04-01 - Last updated in NVD database

Technical Details for CVE-2026-34585

Vulnerability Analysis

This vulnerability resides in SiYuan's handling of Inline Attribute Lists (IAL) within .sy document files. The application implements server-side escaping to prevent malicious content in block attributes from being rendered as executable HTML. However, the escaping logic can be bypassed when an attacker crafts attribute values that mix HTML entities with raw special characters.

When a victim imports a malicious .sy.zip archive through the standard "Import -> SiYuan .sy.zip" workflow and opens the affected note, the crafted attribute value breaks out of its intended HTML context. This allows injection of arbitrary event handlers, resulting in stored XSS that executes whenever the note is viewed.

The severity is significantly amplified in the Electron desktop client environment. Unlike browser-based XSS where exploitation is constrained by the browser sandbox, Electron applications provide JavaScript code with direct access to Node.js APIs. This means the injected script can execute system commands, access the file system, install malware, or perform any action with the privileges of the current user.

Root Cause

The root cause is an incomplete input validation and output encoding implementation in SiYuan's attribute handling logic. The server-side escaping mechanism fails to account for edge cases where HTML entities and raw special characters are combined in specific sequences. This creates a bypass condition where the attribute value can escape its intended HTML attribute context and inject executable content into the DOM.

The CWE-79 (Improper Neutralization of Input During Web Page Generation) classification accurately identifies this as a cross-site scripting vulnerability stemming from insufficient output encoding.

Attack Vector

The attack requires social engineering to deliver the malicious payload. An attacker creates a .sy document file containing a block with a specially crafted IAL value designed to bypass the escaping mechanism. This document is packaged as a .sy.zip archive and distributed to potential victims through various channels such as:

• Shared note repositories or community forums
• Email attachments disguised as legitimate shared knowledge bases
• Collaboration requests within teams using SiYuan

Once the victim imports the archive using SiYuan's built-in import functionality and opens the compromised note, the malicious attribute value renders in the application's webview. The injected JavaScript executes automatically, and in the Electron client, this script has full access to Node.js APIs, enabling arbitrary command execution on the victim's system.

The attack exploits user interaction (importing and viewing a document) but requires no special privileges from the attacker beyond the ability to craft the malicious document.

Detection Methods for CVE-2026-34585

Indicators of Compromise

• Unusual .sy.zip files from untrusted sources containing suspicious IAL attribute patterns
• SiYuan documents with block attributes containing mixed HTML entities and special characters
• Unexpected process spawning from the SiYuan Electron process (e.g., cmd.exe, powershell.exe, /bin/sh)
• Network connections initiated by the SiYuan process to unknown external hosts

Detection Strategies

• Monitor SiYuan application logs for rendering errors or unusual attribute processing behavior
• Implement endpoint detection rules for child process creation from Electron-based applications
• Deploy file integrity monitoring on SiYuan data directories to detect suspicious document modifications
• Analyze imported .sy.zip files for malformed or suspicious attribute values before allowing import

Monitoring Recommendations

• Enable verbose logging in SiYuan to capture document import and rendering events
• Configure EDR solutions to alert on Node.js/Electron applications spawning shell processes
• Establish baseline behavior for SiYuan network activity and alert on anomalies
• Monitor for filesystem access patterns inconsistent with normal note-taking operations

How to Mitigate CVE-2026-34585

Immediate Actions Required

• Upgrade SiYuan to version 3.6.2 or later immediately
• Avoid importing .sy.zip files from untrusted or unknown sources
• Review recently imported documents for suspicious content if running a vulnerable version
• Consider temporarily disabling the import functionality in high-risk environments until patching is complete

Patch Information

The SiYuan development team has addressed this vulnerability in version 3.6.2. The patch corrects the server-side attribute escaping logic to properly handle edge cases involving mixed HTML entities and special characters. Organizations should update to this version through the standard update mechanism or by downloading from the official GitHub release.

For detailed technical information about the vulnerability and the fix, refer to the GitHub Security Advisory GHSA-ff66-236v-p4fg and the related GitHub Issue #17246.

Workarounds

• Use the web-based version of SiYuan instead of the Electron desktop client to limit RCE impact
• Implement strict document import policies requiring manual review of .sy.zip contents before import
• Deploy application-level sandboxing or containerization for the SiYuan desktop application
• Disable JavaScript execution in the application if configuration options allow (may impact functionality)

# Verify SiYuan version to confirm patch status
# Check the application's About page or run:
siyuan --version

# Ensure version is 3.6.2 or higher
# If using package managers, update with:
# For manual installations, download from:
# https://github.com/siyuan-note/siyuan/releases/tag/v3.6.2